-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Reproduce issue 14685 #14909
tests: Reproduce issue 14685 #14909
Conversation
8c90fc5
to
898ed88
Compare
Makefile
Outdated
mkdir -p /tmp/etcd-release-v3.5.5/ | ||
cd /tmp/etcd-release-v3.5.5/; \ | ||
git clone https://github.com/etcd-io/etcd.git .; \ | ||
git checkout v3.5.5; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment #14912 (comment) applies to this PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this PR as draft until we resolve #14912 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the script. PTAL.
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
898ed88
to
b108fab
Compare
Codecov Report
@@ Coverage Diff @@
## main #14909 +/- ##
==========================================
- Coverage 74.75% 74.56% -0.19%
==========================================
Files 415 415
Lines 34338 34267 -71
==========================================
- Hits 25669 25552 -117
- Misses 7034 7069 +35
- Partials 1635 1646 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @serathius
Interesting we got an inconsistency on GitHub side. Commit for this PR was merged but not the PR. |
Verified locally that this reproduces #14685
cc @ahrtr @ptabor @geetasg @tjungblu
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.