Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] backports #11990 #12933 #15072

Closed
wants to merge 6 commits into from
Closed

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Jan 9, 2023

It is trying to backport two improvements into release 3.4.

Click to check rw-heatmap benchmark result

Use https://github.com/fuweid/etcd/tree/tools-use-imshow-instead-of-tripcolor to render heatmap

backports_read
backports_write

backports-based-on-v3.4.23.csv
v3.4.23.csv

Click to check range not-found key benchmark result

Based on steps provided by #11783, the script is like

   cd /data
    export CLIENT_PORT="23790"
    export BACKEND_SIZE="$((20 * 1024 * 1024 * 1024))"
    /root/etcd/bin/etcd --quota-backend-bytes=${BACKEND_SIZE} \
      --log-level 'error' \
      --listen-client-urls http://0.0.0.0:${CLIENT_PORT} \
      --advertise-client-urls http://127.0.0.1:${CLIENT_PORT} \
      &>/dev/null &
    sleep 5

    /root/etcd/bin/tools/benchmark --endpoints http://127.0.0.1:${CLIENT_PORT} \
       --clients 1000 --conns 100 \
       put --key-size 8 --val-size 256 --total 100000

    sleep 2

    /root/etcd/bin/tools/benchmark --endpoints http://127.0.0.1:${CLIENT_PORT} \
       --clients 1000 --conns 100 \
       range 12345678123456781234567812345678 --consistency=l --total 100000
  • v3.4.23: Requests/sec: 26169.3610
  • Backport: Requests/sec: 127041.7200

Hope it is acceptable!

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

mlmhl and others added 6 commits January 9, 2023 18:46
(cherry picked from commit aa7b056)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 730f3f1)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 3594ab9)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 26c930f)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 182aef6)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 9c82e8c)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
Copy link
Member Author

fuweid commented Jan 10, 2023

ping @ahrtr @ptabor @serathius ~

The CI fails because of exiting flaky cases. When the lease is not found, the grpcproxy closes connection instead of returning error. So the case got curl: (52) Empty reply from server

@ahrtr
Copy link
Member

ahrtr commented Jan 10, 2023

Usually we only backport bug fixes, but this PR backports features. Especially release-3.4 has more than 3 years of history, stability is even more important.

Note: backporting multiple features in one PR is not good to me. I prefer to backport only one change in one PR.

@fuweid
Copy link
Member Author

fuweid commented Jan 11, 2023

@ahrtr Thanks for the comment.

I will split it into several prs and seek the comments from yours~.
Before that, I am working on fixing the existing flaky cases in v3.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants