tests: Add defragment request to linearizability tests #15178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15178 +/- ##
==========================================
+ Coverage 74.56% 74.60% +0.04%
==========================================
Files 415 415
Lines 34320 34320
==========================================
+ Hits 25590 25605 +15
+ Misses 7085 7078 -7
+ Partials 1645 1637 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
reviewed
Jan 24, 2023
Comment on lines
+301
to
+303
| if !reflect.DeepEqual(newState, s) { | ||
| states = append(states, newState) | ||
| } |
There was a problem hiding this comment.
Could you clarify this change? Shouldn't we always cache the state for failed request?
There was a problem hiding this comment.
I'm adding an exception because of the new Defragment request. As defragment does not impact etcd results, the etcd state does not change. If etcd state does not change, there is no need to "cache" the state on failed request.
ahrtr
approved these changes
Jan 24, 2023
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
linearizability-defrag
branch
from
2619672
to
c50e602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @ptabor