-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E tests on arm64 #15230
Add E2E tests on arm64 #15230
Conversation
This PR is regarded with #14748 Just a PR to add e2e test for Arm64 to check if it is green. |
@dims @geetasg @chaochn47 first time commit here, so needs maintainers to approve first. Thanks! |
I think we need to add similar tests (see below) for ARM64,
And remove https://github.com/etcd-io/etcd/blob/main/.github/workflows/functional-arm64.yaml |
Hi @ahrtr, thanks! The reason why it is located to a separate file is that it needs to run on a special Arm64 node and also this will be changed to periodical job. |
@@ -0,0 +1,31 @@ | |||
name: E2E-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a separate workflow, can you add arm64 as a job to existing "E2E" workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work because the ARM machines have different labels. FYI. #15172 (comment)
Probably we can add a template to be shared by both the existing E2E workflow and ARM64. But I don't think it's a big deal, It's OK to leave it as it's for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels are per job not per workflow.
jobs:
test:
runs-on: [Linux, ARM64]
You can change it to:
jobs:
amd64:
runs-on: ubuntu-latest
...
arm64:
runs-on: [Linux, ARM64]
Why? |
@ahrtr the aim is not to be a bottleneck to the current set of CI jobs that are run before we land a PR. The problem is we have only 2 github runners for arm64 and if we have a lot of PRs in flight the time that folks have to wait to land something will be a lot. |
Makes sense. Thanks @dims for the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr Thanks! Modify to periodical job now. The perviously submit for the e2e-arm64 job is green. |
Please squash the commits. |
Now it is daily nightly build at 1 am. Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>
a9e2feb
to
009a6c0
Compare
Thanks! Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kevinzs2048
Signed-off-by: Kevin Zhao kevin.zhao@linaro.org
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.