Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Backport adjusting time resolution to microseconds #15241

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Feb 3, 2023

This is a backport of #15239.

Historic capnslog timestamps are in microsecond resolution. We need to match that when we migrate to the zap logger.

@ahrtr
Copy link
Member

ahrtr commented Feb 9, 2023

@jmhbnz Please rebase this PR and resolve the pipeline error.

Historic capnslog timestamps are in microsecond resolution. We need to match that when we migrate to the zap logger.

Signed-off-by: James Blair <mail@jamesblair.net>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @jmhbnz

@ahrtr
Copy link
Member

ahrtr commented Feb 9, 2023

@jmhbnz Please also add changelog items for both 3.4 and 3.5

@ahrtr ahrtr merged commit d32dceb into etcd-io:release-3.4 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants