Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run go mod tidy #15454

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Run go mod tidy #15454

merged 1 commit into from
Mar 14, 2023

Conversation

serathius
Copy link
Member

@serathius
Run go mod tidy
e44995e 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
jmhbnz
jmhbnz approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ahrtr
Copy link
Member

ahrtr commented Mar 14, 2023

The PR #15337 forgot to update the go version in raft/go.mod, client/v2/go.mod, client/v3/go.mod and pkg/go.mod. The release workflow failed in that PR, because the release always runs against release-3.5, so we ignored the error.

But what's confusing me is why the workflow succeeded after @ptabor merged that PR in c602942. There may be something wrong.

Anyway, thanks for the fix. Let's merge it to unblock any following PRs against release-3.5.

ahrtr
ahrtr approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 6ddb23c into etcd-io:release-3.5 Mar 14, 2023
@serathius serathius deleted the gomodtidy-3.5 branch June 15, 2023 20:38
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
@ahrtr @tjungblu
Merge pull request etcd-io#15454 from serathius/gomodtidy-3.5
a2c74f6 
Run go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @ahrtr @jmhbnz