Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] chore: enable strict mode for test CI #15558

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Mar 26, 2023

@fuweid fuweid marked this pull request as ready for review March 26, 2023 03:11
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @fuweid

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid force-pushed the 3.5-use-strict-mode-for-test branch from 36d41ec to 55bce22 Compare April 2, 2023 00:58
@fuweid
Copy link
Member Author

fuweid commented Apr 2, 2023

@ahrtr @serathius fixed the conflict. please take a look.

@ahrtr ahrtr merged commit 65635e4 into etcd-io:release-3.5 Apr 2, 2023
@fuweid fuweid deleted the 3.5-use-strict-mode-for-test branch April 2, 2023 03:00
@fuweid
Copy link
Member Author

fuweid commented Apr 2, 2023

Thanks @ahrtr !

tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
…test

[3.5] chore: enable strict mode for test CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants