chore: cleanup #15514 (Rewrite etcd scripts in strict mode)

[fuweid]

• chore: use tools/mod to lock the cfssl cmd version
• chore: add strict mode for pkg/proxy/fixtures/gencerts.sh
• chore: add strict mode to scripts/test_lib.sh
• chore: use strict mode for tests//.sh
• chore: deprecate tests/manual folder

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[serathius]

LGTM. Great cleanup!

Some background, those scripts were already broken when I joined the project. We left them so someone maybe will want to fix them, however no-one wanted to use manual tests and robustness tests automated majority of the tests done here.

[fuweid]

Rebased! Mark it ready to review.

[fuweid]

ping @serathius @ahrtr ~

[jmhbnz]

LGTM, nice work @fuweid

[chaochn47]

Some background, those scripts were already broken when I joined the project. We left them so someone maybe will want to fix them, however no-one wanted to use manual tests

I don't see the original manual test commit was justified with any test results or associated with a PR with discussion a2256a6.

I agree we should delete not maintained manual test scripts and in favor of automated tests that are verified continuously.

[ahrtr]

FYI. -mod=mod tells the go command to ignore the vendor directory and to [automatically update](https://go.dev/ref/mod#go-mod-file-updates) go.mod, for example, when an imported package is not provided by any known module.. I don't think it should automatically update the go.mod file. See https://go.dev/ref/mod#build-commands.

This comment applies to a couple of places below.

Suggested change

	echo "use: go install -mod mod github.com/cloudflare/cfssl/cmd/cfssl"
	echo "use: go install github.com/cloudflare/cfssl/cmd/cfssl"

[fuweid]

You're right. It will dirty the go.mod if the user runs the command in the repo. I updated with your suggestion. Please take a look. Thanks!

[ahrtr]

Please consider to install a specific version of tool (e.g. cfssl in this case).

Usually we specify the version in tools/mod:

1. import the package in tools/mod/tools.go;
2. specify the version in tools/mod/go.mod;
3. Execute cd tools/mod; go install github.com/cloudflare/cfssl/cmd/cfssl

This can be resolved in a separate PR.

[fuweid]

Sure! That makes sense. Will file other pr later.

[fuweid]

cluster_test.go:326: expect error to contain can only promote a learner member, got etcdserver: request timed out

TestMemberPromoteMemberNotLearner is flaky as known issue. Need a maintainer to retry~ Thanks

[ahrtr]

LGTM with a minor comment, which can be resolved separately.

Thank you @fuweid

[ahrtr]

It still has "-mod mod"

Suggested change

	echo "use: go install -mod mod github.com/cloudflare/cfssl/cmd/cfssl"
	echo "use: go install github.com/cloudflare/cfssl/cmd/cfssl"

[ahrtr]

This comment applies to some places below as well.

Note that this script may be executed at any directory, so set the absolute directory is better.

Suggested change

	echo 'use: bash -c "cd ../../../tools/mod; go install github.com/cloudflare/cfssl/cmd/cfssl"'
	echo 'use: bash -c "cd ${ETCD_ROOT_DIR}/tools/mod; go install github.com/cloudflare/cfssl/cmd/cfssl"'

[fuweid]

This script is only allowed to run in current dir.

if ! [[ "$0" =~ "./gencerts.sh" ]]; then
  echo "must be run from 'fixtures'"
  exit 255
fi

So I was thinking that the user can copy-parse the echo string to install.
If we use ETCD_ROOT_DIR, the user needs to get the root dir path first.

I can add one line to resolve ETCD_ROOT_DIR first.

[ahrtr]

OK, then let's keep it as it is for now.