migrate e2e auth tests to common #8 #15867
Conversation
| @@ -303,29 +296,6 @@ func authTestWatch(cx ctlCtx) { | |||
|
|
|||
| } | |||
|
|
|||
| func authTestDefrag(cx ctlCtx) { | |||
There was a problem hiding this comment.
It has been replaced by https://github.com/etcd-io/etcd/blob/main/tests/common/maintenance_auth_test.go#L33-L53
| @@ -420,83 +420,6 @@ func TestV3AuthOldRevConcurrent(t *testing.T) { | |||
| wg.Wait() | |||
| } | |||
|
|
|||
| func TestV3AuthRestartMember(t *testing.T) { | |||
There was a problem hiding this comment.
It is the same verification as authTestCacheReload in ctl_v3_auth_test.go and it was added in #14358
| @@ -583,86 +506,3 @@ func TestV3AuthWatchErrorAndWatchId0(t *testing.T) { | |||
|
|
|||
| <-watchEndCh | |||
| } | |||
|
|
|||
| func TestV3AuthWithLeaseTimeToLive(t *testing.T) { | |||
There was a problem hiding this comment.
It is the same verification of authTestLeaseTimeToLive in ctl_v3_auth_test.go and was added in #15656
| <-time.After(3 * time.Second) | ||
|
|
||
| // e2e test will generate a new token while | ||
| // integration test that re-uses the same etcd client will refresh the token on server failure. |
There was a problem hiding this comment.
Could we validate that we refreshed token?
There was a problem hiding this comment.
Yeah, it is feasible if
- etcd server log level is debug level
- capture the etcd server log output
Lines 339 to 343 in 4da39e4
| clus.Members()[0].Stop() | ||
| require.NoError(t, clus.Members()[0].Start(ctx)) | ||
|
|
||
| // nothing has changed, but it fails without refreshing cache after restart |
There was a problem hiding this comment.
Don't understand this comment. How do we know it would fail?
There was a problem hiding this comment.
Without this refreshRangePermCache in NewAuthStore on server restart,
Line 973 in 4da39e4
permissions are not reloaded from disk. So this test will fail.
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
auth_test_split_8
branch
from
0cdd36a
to
c846b08
Compare
Related to the ask from #14041 to split tests into smaller pieces. This PR is the last one and should close #14041.
So code review will be reviewer friendly and easier to reason about.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
/cc @ahrtr @serathius @mitake @ptabor @fuweid