Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental-compact-hash-check-enabled to help #16031

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Jun 8, 2023

add experimental-compact-hash-check-enabled and experimental-compact-hash-check-time to help.

Signed-off-by: scuzk373x@gmai.com <zhuanwajiang@pinduoduo.com>
@kkkkun kkkkun force-pushed the add_experimental_hash_check_to_help branch from ab233f0 to 798d2b7 Compare June 8, 2023 06:30
@kkkkun kkkkun changed the title add compact hash check to help add add experimental-compact-hash-check-enabled to help to help Jun 8, 2023
@kkkkun kkkkun changed the title add add experimental-compact-hash-check-enabled to help to help add experimental-compact-hash-check-enabled to help Jun 8, 2023
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @kkkkun.

@serathius
Copy link
Member

Could someone look into automating generation of help? Example kubernetes-sigs/metrics-server#939

@jmhbnz
Copy link
Member

jmhbnz commented Jun 8, 2023

Could someone look into automating generation of help? Example kubernetes-sigs/metrics-server#939

Good idea. Raised our follow-up #16034

@kkkkun
Copy link
Contributor Author

kkkkun commented Jun 8, 2023

Could someone look into automating generation of help? Example kubernetes-sigs/metrics-server#939

Yes,I think it's useful.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kkkkun

ahrtr added a commit that referenced this pull request Jun 12, 2023
@ahrtr ahrtr merged commit c104a4d into etcd-io:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants