-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from v2.7.0 to v2.17.1 #16357
Conversation
|
oops, fixed |
etcd doesn't directly depend on Usually we don't bump indirect dependencies directly [unless there is an urgent CVE or critical bug fix], because we don't know what compatibility issue it may cause. Instead, they (the indirect dependencies) will be automatically bumped each time when we bump the related direct dependencies. I believe this is also the reason why you do not bump Note that the grpc-gateway/v2 is already on the latest version v2.16.2 in otlptracegrpc's main branch. References: |
Eventually we will upgrade grpc-gateway to v2 in #16454. But just as I mentioned in #16454 (comment), I'd like to breakdown the big change, so I am happy to get this PR merged firstly. Could you please rebase this PR and bump grpc-gateway to latest version 2.17.1? Please feel free to let me know if you don't bandwidth to do it, than I can take care of it. |
done |
Could you rebase this PR although github doesn't show conflict? Your dev branch is far lag behind the head of main branch; sometimes github can't detect some conflict. |
actually done this time :) |
The workflow fails due to inconsistent google.golang.org/genproto/googleapis/api versions. Please refer to 40c7f72 |
0bb99e6
to
90a2175
Compare
…0 to v2.17.1 Signed-off-by: Jordan Liggitt <liggitt@google.com>
finally got it green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the grpc-gateway dependency to pick up grpc-ecosystem/grpc-gateway#3317
This removes the direct dependency on google.golang.org/genproto (which clears the way to clean up that dependency tree once google.golang.org/genproto/googleapis/rpc drops the reference to google.golang.org/genproto, see googleapis/go-genproto#1015 for details)