-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Backport #12671 clientv3: Replace balancer with upstream grpc solution #16844
[3.4] Backport #12671 clientv3: Replace balancer with upstream grpc solution #16844
Conversation
Proxy test failed. https://github.com/etcd-io/etcd/actions/runs/6672706002/job/18137135993?pr=16844 I have to backport its follow up PR to make CI green. |
eb92e28
to
cbf686a
Compare
There are two changes with grpc proxy in #12706,
|
I assume we want to reduce the moving parts for the sake of bumping up gRPC versions, so I stripped this change. Does that make sense to you? @ahrtr |
Yeah, I could have documented it clearer. @ahrtr Other than this contentious change, is there anything else I should follow up for this PR? |
Overall looks good to me. The only minor comment is #16844 (comment) Thanks. |
cbf686a
to
69a2c6f
Compare
Just merged #16849, please rebase this PR. |
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
69a2c6f
to
3a0dd2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backports LGTM - Thanks @chaochn47
Breakdown of #16827
Backports
Changes made on top of the original PR:
go.mod
andgo.sum
files are removedclientv3
pathPlease read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.