Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4]Add a unit tests and missing flags in etcd help. #17202

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ishan16696
Copy link
Contributor

@ishan16696 ishan16696 commented Jan 5, 2024

Fixes : #16034 for etcd v3.4
Backport: #16465

Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
@k8s-ci-robot
Copy link

Hi @ishan16696. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ishan16696 ishan16696 changed the title Add a unit tests and missing flags in etcd help. [3.4]Add a unit tests and missing flags in etcd help. Jan 5, 2024
@serathius
Copy link
Member

cc @ahrtr

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ahrtr ahrtr merged commit c7eab9d into etcd-io:release-3.4 Jan 5, 2024
12 checks passed
@ishan16696 ishan16696 deleted the Backport-PR16465-3.4 branch January 5, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants