Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] dependency: update go to 1.20.13 #17276

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 18, 2024

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Upgrades go version to 1.20.13.

Part of #17269.

@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jan 18, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately our release-3.4 branch still has multiple places where go version is referenced:

 ~  Documents  etcd  ?1  3.4-update-golang-t..  grep -Ri '1\.20\.12'
Makefile:GO_VERSION ?= 1.20.12
functional/scripts/docker-local-tester.sh:  GO_VERSION=1.20.12
functional/scripts/docker-local-agent.sh:  GO_VERSION=1.20.12

Suggest we update those as well, or add a second commit to this pr which makes those three all refer to the single file to fix it for good.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 18, 2024

Unfortunately our release-3.4 branch still has multiple places where go version is referenced:

 ~  Documents  etcd  ?1  3.4-update-golang-t..  grep -Ri '1\.20\.12'
Makefile:GO_VERSION ?= 1.20.12
functional/scripts/docker-local-tester.sh:  GO_VERSION=1.20.12
functional/scripts/docker-local-agent.sh:  GO_VERSION=1.20.12

Suggest we update those as well, or add a second commit to this pr which makes those three all refer to the single file to fix it for good.

Oops, I missed those ones. I'll update them and will amend my commit.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the 3.4-update-golang-to-1.20.13 branch from 56699ac to 5d0fbaf Compare January 19, 2024 00:13
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on workflow green - thanks @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thank you!

@jmhbnz
Copy link
Member

jmhbnz commented Jan 20, 2024

/retest

@ahrtr
Copy link
Member

ahrtr commented Jan 22, 2024

The linux-amd64-e2e has timed out for 5 times.

Could you take #17241 as a high priority task? @fuweid thx

@fuweid
Copy link
Member

fuweid commented Jan 23, 2024

Found the root cause and will file pr later.

@ahrtr ahrtr merged commit 7555d0c into etcd-io:release-3.4 Jan 23, 2024
11 of 12 checks passed
@fuweid
Copy link
Member

fuweid commented Jan 23, 2024

FYI, CI is happy right now https://github.com/etcd-io/etcd/actions/runs/7627029235

@ivanvc ivanvc deleted the 3.4-update-golang-to-1.20.13 branch January 23, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants