-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] dependency: update go to 1.20.13 #17276
[3.4] dependency: update go to 1.20.13 #17276
Conversation
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately our release-3.4
branch still has multiple places where go version is referenced:
~ Documents etcd ?1 3.4-update-golang-t.. grep -Ri '1\.20\.12'
Makefile:GO_VERSION ?= 1.20.12
functional/scripts/docker-local-tester.sh: GO_VERSION=1.20.12
functional/scripts/docker-local-agent.sh: GO_VERSION=1.20.12
Suggest we update those as well, or add a second commit to this pr which makes those three all refer to the single file to fix it for good.
Oops, I missed those ones. I'll update them and will amend my commit. |
Signed-off-by: Ivan Valdes <ivan@vald.es>
56699ac
to
5d0fbaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on workflow green - thanks @ivanvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you!
/retest |
Found the root cause and will file pr later. |
FYI, CI is happy right now https://github.com/etcd-io/etcd/actions/runs/7627029235 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Upgrades go version to 1.20.13.
Part of #17269.