Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go1.22 #17393

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Migrate to go1.22 #17393

merged 1 commit into from
Mar 7, 2024

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented Feb 7, 2024

Migrate main to golang 1.22.

One task towards #17348

Ran some benchmarks between this branch and main locally as follows:

# Server
GOMAXPROCS=10 ./bin/etcd --quota-backend-bytes=17179869184 --listen-client-urls http://0.0.0.0:23790 --advertise-client-urls http://127.0.0.1:23790

# Benchmark
GOMAXPROCS=6 go run ./tools/benchmark put --conns=64 --clients=64 --key-size=256 --val-size=4096 --key-space-size=50000 --total=2000000 --endpoints "http://127.0.0.1:23790"

# make clean && make build between each run
Run 1 Run 2 Run 3
main
etcd Version: 3.6.0-alpha.0
Go Version: go1.21.6
Go OS/Arch: linux/amd64
Summary:
Total: 631.2755 secs.
Slowest: 0.1076 secs.
Fastest: 0.0028 secs.
Average: 0.0202 secs.
Stddev: 0.0092 secs.
Requests/sec: 3168.1889
Summary:
Total: 679.5380 secs.
Slowest: 0.1487 secs.
Fastest: 0.0027 secs.
Average: 0.0217 secs.
Stddev: 0.0097 secs.
Requests/sec: 2943.1761
Summary:
Total: 669.9843 secs.
Slowest: 0.1206 secs.
Fastest: 0.0026 secs.
Average: 0.0214 secs.
Stddev: 0.0097 secs.
Requests/sec: 2985.1447
this branch
etcd Version: 3.6.0-alpha.0
Go Version: go1.22.0
Go OS/Arch: linux/amd64
Summary:
Total: 651.7652 secs.
Slowest: 0.1282 secs.
Fastest: 0.0033 secs.
Average: 0.0209 secs.
Stddev: 0.0099 secs.
Requests/sec: 3068.5899
Summary:
Total: 647.3450 secs.
Slowest: 0.1279 secs.
Fastest: 0.0030 secs.
Average: 0.0207 secs.
Stddev: 0.0097 secs.
Requests/sec: 3089.5426
Summary:
Total: 699.5499 secs.
Slowest: 0.1271 secs.
Fastest: 0.0033 secs.
Average: 0.0224 secs.
Stddev: 0.0097 secs.
Requests/sec: 2858.9813

@k8s-ci-robot
Copy link

Hi @dusk125. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr
Copy link
Member

ahrtr commented Feb 7, 2024

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Feb 8, 2024

/test pull-etcd-unit-test

@ahrtr
Copy link
Member

ahrtr commented Feb 8, 2024

I see there are some issue against go 1.22, let's on-hold bumping 1.22 for a while.

.go-version Outdated Show resolved Hide resolved
@dusk125 dusk125 force-pushed the go1.22 branch 4 times, most recently from 8fccb39 to 5394ff1 Compare March 6, 2024 21:42
Signed-off-by: Allen Ray <alray@redhat.com>
@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

We need to bump google.golang.org/protobuf to 1.33.0 to resolve the CVE
https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.33.0

@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

We have to merge this PR firstly, and let #17543 to take care of bumping google.golang.org/protobuf to 1.33.0

@ahrtr ahrtr merged commit a481256 into etcd-io:main Mar 7, 2024
38 of 39 checks passed
@dusk125 dusk125 deleted the go1.22 branch March 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants