-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to go1.22 #17393
Migrate to go1.22 #17393
Conversation
Hi @dusk125. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-etcd-unit-test |
I see there are some issue against go 1.22, let's on-hold bumping 1.22 for a while.
|
8fccb39
to
5394ff1
Compare
Signed-off-by: Allen Ray <alray@redhat.com>
We need to bump google.golang.org/protobuf to 1.33.0 to resolve the CVE |
We have to merge this PR firstly, and let #17543 to take care of bumping google.golang.org/protobuf to 1.33.0 |
Migrate main to golang 1.22.
One task towards #17348
Ran some benchmarks between this branch and main locally as follows:
etcd Version: 3.6.0-alpha.0
Go Version: go1.21.6
Go OS/Arch: linux/amd64
Total: 631.2755 secs.
Slowest: 0.1076 secs.
Fastest: 0.0028 secs.
Average: 0.0202 secs.
Stddev: 0.0092 secs.
Requests/sec: 3168.1889
Total: 679.5380 secs.
Slowest: 0.1487 secs.
Fastest: 0.0027 secs.
Average: 0.0217 secs.
Stddev: 0.0097 secs.
Requests/sec: 2943.1761
Total: 669.9843 secs.
Slowest: 0.1206 secs.
Fastest: 0.0026 secs.
Average: 0.0214 secs.
Stddev: 0.0097 secs.
Requests/sec: 2985.1447
etcd Version: 3.6.0-alpha.0
Go Version: go1.22.0
Go OS/Arch: linux/amd64
Total: 651.7652 secs.
Slowest: 0.1282 secs.
Fastest: 0.0033 secs.
Average: 0.0209 secs.
Stddev: 0.0099 secs.
Requests/sec: 3068.5899
Total: 647.3450 secs.
Slowest: 0.1279 secs.
Fastest: 0.0030 secs.
Average: 0.0207 secs.
Stddev: 0.0097 secs.
Requests/sec: 3089.5426
Total: 699.5499 secs.
Slowest: 0.1271 secs.
Fastest: 0.0033 secs.
Average: 0.0224 secs.
Stddev: 0.0097 secs.
Requests/sec: 2858.9813