[3.5] feat: add wal write system call metrics observation

[Akiqqqqqqq]

xref. #17615

add new metrics: wal_write_duration_seconds

wal_write_duration_seconds represent total delay of:

syscall.write(padding_info + record_data_with_padding)

• delay of fsync is not included in wal_write_duration_seconds
• data: the raft log to write to the WAL on disk at one single raftNode loop

[k8s-ci-robot]

Hi @Akiqqqqqqq. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmhbnz]

/ok-to-test

[liangyuanpeng]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

Remind me if i missed something.

[jmhbnz]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

Very strange. I have not seen this issue before. Can you please rebase and force push to trigger the workflows again?

[Akiqqqqqqq]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

Very strange. I have not seen this issue before. Can you please rebase and force push to trigger the workflows again?

to be sure, so do I need to perfrom again?
git rebase HEAD~1 --signoff
and
git push -f

[Akiqqqqqqq]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

Very strange. I have not seen this issue before. Can you please rebase and force push to trigger the workflows again?

I retried, but seems to be not working

[jmhbnz]

I retried, but seems to be not working

Closing and re-opening the pr seems to have fixed it 😅

[jmhbnz]

LGTM - Reading through the linked issue I think this addition makes sense, thanks @Akiqqqqqqq for drafting the pr.

Edit: Note if we do go ahead with merging this we need to update docs etc for the new metric.

[liangyuanpeng]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

This caught my attention, so I looked into it a little deeper. I found out that this PR was being submitted for release-3.5 instead of main, and the release-3.5 branch didn't have the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml , so this is the reason the github acton workflow wasn't being run by approve .

I think we should create a PR to the main first?

[Akiqqqqqqq]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

This caught my attention, so I looked into it a little deeper. I found out that this PR was being submitted for release-3.5 instead of main, and the release-3.5 branch didn't have the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml , so this is the reason the github acton workflow wasn't being run by approve .

I think we should create a PR to the main first?

ok， let me raise another PR to main

[Akiqqqqqqq]

Seem like the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml have some problem here? Exist label of ok-to-test but not approve this PR to run github action.

This caught my attention, so I looked into it a little deeper. I found out that this PR was being submitted for release-3.5 instead of main, and the release-3.5 branch didn't have the workflow of https://github.com/etcd-io/etcd/blob/main/.github/workflows/gh-workflow-approve.yaml , so this is the reason the github acton workflow wasn't being run by approve .

I think we should create a PR to the main first?

check this out: #17618

[jmhbnz]

I think we should create a PR to the main first?

Yes good catch - let's merge #17618 first.

[ivanvc]

/retitle [3.5] feat: add wal write system call metrics observation

[ahrtr]

Please link to the original PR next time when backporting any PR,

• feat: add wal write system call metrics observation (main) #17618

[Akiqqqqqqq]

#17615

got it