Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/mod: remove reference to github.com/mikefarah/yq/v4 #17659

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 27, 2024

yq was a tool initially used to get the project's Go version when it was running on Travis CI. This was removed at the commit 577c898, and the project currently uses .go-version to specify the Go version. Therefore, we can safely delete this dependency.

Fixes #17658.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

`yq` was a tool initially used to get the project's Go version when it
was running on Travis CI. This was removed at the commit
577c898, and the project currently uses
`.go-version` to specify the Go version. Therefore, we can safely delete
this dependency.

Signed-off-by: Ivan Valdes <ivan@vald.es>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for tidying this up @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice work.

@ahrtr ahrtr merged commit 4af78d4 into etcd-io:main Mar 27, 2024
38 checks passed
@ivanvc ivanvc deleted the remove-yq-from-tools-mod branch March 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove yq from tools/mod
4 participants