[3.4] fix grpc proxy member list not updated with node deletion #17896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If grpc starts with `--resolver-prefix`, its memberlist will return all alive proxy nodes. When one GRPC proxy node goes down it shouldn't return that node, however, it's returned. Backport of PR etcd-io#15907 / commit ecfed91. Co-authored-by: yellowzf <zzhf3311@163.com> Signed-off-by: Ivan Valdes <ivan@vald.es>
4 tasks
ahrtr
approved these changes
Apr 29, 2024
ivanvc
deleted the
release-3.4-fix-grpc-proxy-member-list-not-updated-with-node-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If grpc starts with
--resolver-prefix, its memberlist will return all alive proxy nodes. When one GRPC proxy node goes down, it shouldn't return that node. However, it's returned.Backport of PR #15907 / commit ecfed91.
Part to #17887.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.