Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending Compact request when LazyFS is enabled #18181

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

serathius
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.86%. Comparing base (15f9a59) to head (abd66da).
Report is 2 commits behind head on main.

Current head abd66da differs from pull request most recent head 42f8fd1

Please upload reports for the commit 42f8fd1 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/storage/mvcc/revision.go 91.48% <80.00%> (-3.39%) ⬇️
etcdutl/snapshot/v3_snapshot.go 57.43% <64.00%> (+8.53%) ⬆️

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18181      +/-   ##
==========================================
+ Coverage   68.75%   68.86%   +0.10%     
==========================================
  Files         416      416              
  Lines       35128    35151      +23     
==========================================
+ Hits        24152    24206      +54     
+ Misses       9569     9536      -33     
- Partials     1407     1409       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f9a59...42f8fd1. Read the comment docs.

@serathius
Copy link
Member Author

cc @fuweid @MadhavJivrajani

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@serathius serathius merged commit c70e0e4 into etcd-io:main Jun 18, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants