Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the error message when client certificate isn't provided for secure metrics url #18203

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jun 18, 2024

…ecure metrics url

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@gyuho
Copy link
Contributor

gyuho commented Jun 18, 2024

lgtm

@ahrtr
Copy link
Member Author

ahrtr commented Jun 18, 2024

BTW, @gyuho please feel free to raise a PR to add yourself as a maintainer if you want. thx

@ahrtr
Copy link
Member Author

ahrtr commented Jun 18, 2024

BTW, @gyuho please feel free to raise a PR to add yourself as a maintainer if you want. thx

FYI. https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md#retiring

@gyuho
Copy link
Contributor

gyuho commented Jun 18, 2024

@ahrtr Haha, thanks. Let me catch up with all the changes in recent years, and we can discuss :)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@ahrtr ahrtr merged commit 908d31a into etcd-io:main Jun 19, 2024
48 checks passed
@ahrtr ahrtr deleted the metrics_url_20240618 branch June 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants