Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go version to 1.22.5: GO-2024-2963 fix. #18270

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Bump Go version to 1.22.5: GO-2024-2963 fix. #18270

merged 1 commit into from
Jul 3, 2024

Conversation

thedtripp
Copy link
Member

@k8s-ci-robot
Copy link

Hi @thedtripp. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thedtripp thedtripp changed the title Bump Go version to 1.225: GO-2024-2963 fix. Bump Go version to 1.22.5: GO-2024-2963 fix. Jul 3, 2024
@thedtripp
Bump Go version to 1.22.5: GO-2024-2963 fix.
8f97466 
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
@thedtripp thedtripp force-pushed the main-go-2024-2963 branch from 277d63d to 8f97466 Compare July 3, 2024 05:07
@thedtripp thedtripp marked this pull request as ready for review July 3, 2024 05:07
@ivanvc
Copy link
Member

ivanvc commented Jul 3, 2024

/ok-to-test

@thedtripp
Copy link
Member Author

/retest

@ivanvc ivanvc mentioned this pull request Jul 3, 2024
Closed
7 tasks
@thedtripp
Copy link
Member Author

/retest

ivanvc
ivanvc approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @thedtripp.

@ahrtr ahrtr merged commit 0a5d905 into etcd-io:main Jul 3, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
area/clientv3 area/etcdctl area/etcdutl area/performance area/testing area/tooling ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thedtripp @k8s-ci-robot @ivanvc @ahrtr