Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted infra-guide #18449

Merged
merged 1 commit into from
Aug 16, 2024
Merged

deleted infra-guide #18449

merged 1 commit into from
Aug 16, 2024

Conversation

TheInvincibleRalph
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @TheInvincibleRalph. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TheInvincibleRalph
Copy link
Contributor Author

@fuweid @technoweenie @drnic @bmizerany

Cleaned up the Infra-guide folder. Kindly review.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheInvincibleRalph - Thanks for tidying this up. Can you please sign your commit to ensure the Developer Certificate of Origin check passes, i.e.:

git reset --soft HEAD~1
git commit --signoff --message "<message>"
git push --force

Additionally it looks like the directory would be empty after that file is removed so we may as well remove the directory also.

Signed-off-by: TheInvincible <adesegunraphaeladeoye@gmail.com>
@TheInvincibleRalph
Copy link
Contributor Author

@jmhbnz. Thank you for the help. Also, I deleted the directory as well.

@jmhbnz
Copy link
Member

jmhbnz commented Aug 16, 2024

/ok-to-test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (39b711f) to head (3890549).
Report is 3 commits behind head on main.

Current head 3890549 differs from pull request most recent head 56e5b1d

Please upload reports for the commit 56e5b1d to get more accurate results.

Files Patch % Lines
server/storage/mvcc/hash.go 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/storage/mvcc/key_index.go 64.70% <100.00%> (+2.27%) ⬆️
server/storage/mvcc/hash.go 97.10% <33.33%> (-2.90%) ⬇️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18449      +/-   ##
==========================================
+ Coverage   68.77%   68.83%   +0.05%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
+ Hits        24407    24428      +21     
+ Misses       9654     9639      -15     
+ Partials     1429     1423       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b711f...56e5b1d. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for helping with this @TheInvincibleRalph 🙏🏻

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius, TheInvincibleRalph

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c8e0d1e into etcd-io:main Aug 16, 2024
47 checks passed
@TheInvincibleRalph
Copy link
Contributor Author

Thank you too, @jmhbnz

@TheInvincibleRalph TheInvincibleRalph deleted the theinvincible branch August 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants