-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleted infra-guide #18449
deleted infra-guide #18449
Conversation
Hi @TheInvincibleRalph. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@fuweid @technoweenie @drnic @bmizerany Cleaned up the Infra-guide folder. Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheInvincibleRalph - Thanks for tidying this up. Can you please sign your commit to ensure the Developer Certificate of Origin check passes, i.e.:
git reset --soft HEAD~1
git commit --signoff --message "<message>"
git push --force
Additionally it looks like the directory would be empty after that file is removed so we may as well remove the directory also.
Signed-off-by: TheInvincible <adesegunraphaeladeoye@gmail.com>
fe9e346
to
56e5b1d
Compare
@jmhbnz. Thank you for the help. Also, I deleted the directory as well. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18449 +/- ##
==========================================
+ Coverage 68.77% 68.83% +0.05%
==========================================
Files 420 420
Lines 35490 35490
==========================================
+ Hits 24407 24428 +21
+ Misses 9654 9639 -15
+ Partials 1429 1423 -6 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for helping with this @TheInvincibleRalph 🙏🏻
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, serathius, TheInvincibleRalph The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you too, @jmhbnz |
No description provided.