-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Disable robustness test detection of #18089 to allow detecting other issues #18453
Conversation
…etecting other issues" This reverts commit 4fe227c. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #18453 +/- ##
==========================================
+ Coverage 68.79% 68.81% +0.01%
==========================================
Files 420 420
Lines 35490 35490
==========================================
+ Hits 24416 24421 +5
+ Misses 9647 9643 -4
+ Partials 1427 1426 -1 Continue to review full report in Codecov by Sentry.
|
/retest |
/hold Need to wait for the fix to be available in all etcd supported branches as we test against them too. |
ping @serathius @ahrtr I backports all the requires patches to release 3.4 and 3.5. Is it ready to move forward? |
Let's GO! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 4fe227c.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
REF: #18274 (comment)