Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable robustness test detection of #18089 to allow detecting other issues #18453

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Aug 16, 2024

…etecting other issues"

This reverts commit 4fe227c.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (62e4433) to head (7763ebc).

Current head 7763ebc differs from pull request most recent head 6cf8729

Please upload reports for the commit 6cf8729 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18453      +/-   ##
==========================================
+ Coverage   68.79%   68.81%   +0.01%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
+ Hits        24416    24421       +5     
+ Misses       9647     9643       -4     
+ Partials     1427     1426       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e4433...6cf8729. Read the comment docs.

@serathius
Copy link
Member

/retest

@serathius
Copy link
Member

/hold

Need to wait for the fix to be available in all etcd supported branches as we test against them too.

@fuweid
Copy link
Member Author

fuweid commented Aug 21, 2024

ping @serathius @ahrtr I backports all the requires patches to release 3.4 and 3.5. Is it ready to move forward?

@serathius
Copy link
Member

Let's GO!

@serathius serathius merged commit cb0cd4b into etcd-io:main Aug 21, 2024
49 checks passed
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants