-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: update changes for issue 18089 #18482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 12 files with indirect coverage changes @@ Coverage Diff @@
## main #18482 +/- ##
==========================================
+ Coverage 68.81% 68.84% +0.03%
==========================================
Files 420 420
Lines 35490 35490
==========================================
+ Hits 24421 24432 +11
+ Misses 9640 9635 -5
+ Partials 1429 1423 -6 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fuweid, etcd server entry lgtm. Question below on adding test changes, I defer to Marek & Benjamin on this.
CHANGELOG/CHANGELOG-3.4.md
Outdated
@@ -8,13 +8,18 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
|
|||
### etcd server | |||
- Fix [performance regression issue caused by the `ensureLeadership` in lease renew](https://github.com/etcd-io/etcd/pull/18440). | |||
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18475) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18475) | |
- [Keep the tombstone during compaction if it happens to be the compaction revision](https://github.com/etcd-io/etcd/pull/18475). |
CHANGELOG/CHANGELOG-3.5.md
Outdated
@@ -8,10 +8,17 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|||
### etcd server | |||
- Fix [performance regression issue caused by the `ensureLeadership` in lease renew](https://github.com/etcd-io/etcd/pull/18439). | |||
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18474) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Link to #18089 |
Signed-off-by: Wei Fu <fuweid89@gmail.com>
f73d6e9
to
8db31b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.