Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: add log for keyCompactions when finished compaction #18516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qsyqian
Copy link
Contributor

@qsyqian qsyqian commented Aug 30, 2024

@k8s-ci-robot
Copy link

Hi @qsyqian. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (68e7122) to head (531fc3e).

Current head 531fc3e differs from pull request most recent head 7fb484c

Please upload reports for the commit 7fb484c to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/kvstore_compaction.go 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18516      +/-   ##
==========================================
+ Coverage   68.77%   68.81%   +0.03%     
==========================================
  Files         420      420              
  Lines       35535    35536       +1     
==========================================
+ Hits        24440    24453      +13     
+ Misses       9660     9654       -6     
+ Partials     1435     1429       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e7122...7fb484c. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Sep 6, 2024

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Sep 13, 2024

@qsyqian please rebase this PR, which should be able to fix the govulncheck workflow failure.

Signed-off-by: qsyqian <qsyqian@gmail.com>
@qsyqian
Copy link
Contributor Author

qsyqian commented Sep 30, 2024

/retest

@qsyqian
Copy link
Contributor Author

qsyqian commented Sep 30, 2024

@qsyqian please rebase this PR, which should be able to fix the govulncheck workflow failure.

@ahrtr Done. Sorry for the late response.

@ahrtr
Copy link
Member

ahrtr commented Sep 30, 2024

/test pull-etcd-integration-1-cpu-amd64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, qsyqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants