Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: add note for the CompactionSleepInterval flag(PR 18514) #18556

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

JalinWang
Copy link
Contributor

Update the CHANGELOG regarding introducing the etcd --experimental-compaction-sleep-interval flag (#18514)

Signed-off-by: Jalin Wang <JalinWang@outlook.com>
@k8s-ci-robot
Copy link

Hi @JalinWang. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (f89dfed) to head (9f54e54).

Current head 9f54e54 differs from pull request most recent head 7fcc3cf

Please upload reports for the commit 7fcc3cf to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18556      +/-   ##
==========================================
- Coverage   68.76%   68.74%   -0.03%     
==========================================
  Files         420      420              
  Lines       35470    35470              
==========================================
- Hits        24391    24383       -8     
- Misses       9658     9666       +8     
  Partials     1421     1421              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89dfed...7fcc3cf. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Sep 9, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @JalinWang

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Jalin.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, JalinWang, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit f928344 into etcd-io:main Sep 10, 2024
45 of 46 checks passed
@JalinWang JalinWang deleted the chore/update-changelog branch September 10, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants