Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpointsFromCluster to reuse clientConfigFromCmd #18742

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 15, 2024

Minor refactoring... try to reuse the common function so as to remove duplication.

Followup of #18723

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (54db7f0) to head (53acdd4).

Current head 53acdd4 differs from pull request most recent head b757772

Please upload reports for the commit b757772 to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/ep_command.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/ep_command.go 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18742      +/-   ##
==========================================
+ Coverage   68.79%   68.91%   +0.11%     
==========================================
  Files         420      420              
  Lines       35493    35481      -12     
==========================================
+ Hits        24419    24450      +31     
+ Misses       9648     9612      -36     
+ Partials     1426     1419       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54db7f0...b757772. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 15, 2024

/test pull-etcd-integration-1-cpu-amd64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 6779a89 into etcd-io:main Oct 16, 2024
34 checks passed
@ahrtr ahrtr deleted the refactor_cfg_20241015 branch October 16, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants