fix: enable errorlint in server directory

[mmorel-35]

This enable errorlint in packages server

Related to #18576

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/assign @jmhbnz

[mmorel-35]

/cc @ahrtr
/cc @serathius

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.31461% with 46 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (18eb5c6) to head (06f52f6).

❗ Current head 06f52f6 differs from pull request most recent head 3abdf61

Please upload reports for the commit 3abdf61 to get more accurate results.

Files with missing lines	Patch %	Lines
server/etcdmain/etcd.go	0.00%	7 Missing ⚠️
server/etcdserver/api/etcdhttp/utils.go	40.00%	6 Missing ⚠️
server/etcdserver/bootstrap.go	0.00%	6 Missing ⚠️
server/etcdserver/api/rafthttp/http.go	50.00%	4 Missing ⚠️
server/embed/config.go	0.00%	3 Missing ⚠️
server/etcdserver/api/v3rpc/watch.go	50.00%	2 Missing ⚠️
server/lease/leasehttp/http.go	0.00%	2 Missing ⚠️
server/storage/backend.go	0.00%	2 Missing ⚠️
server/storage/schema/membership.go	0.00%	2 Missing ⚠️
server/config/config.go	50.00%	1 Missing ⚠️
... and 11 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/api/membership/cluster.go	88.53% <100.00%> (ø)
server/etcdserver/api/membership/errors.go	100.00% <100.00%> (ø)
server/etcdserver/api/membership/storev2.go	45.19% <100.00%> (ø)
server/etcdserver/api/v2discovery/discovery.go	63.67% <100.00%> (+0.15%)	⬆️
server/etcdserver/corrupt.go	89.30% <100.00%> (ø)
server/storage/schema/schema.go	100.00% <100.00%> (ø)
server/storage/wal/wal.go	57.80% <100.00%> (+0.07%)	⬆️
server/config/config.go	79.76% <50.00%> (ø)
server/embed/config_logging.go	51.53% <66.66%> (ø)
server/embed/config_logging_journal_unix.go	0.00% <0.00%> (ø)
... and 18 more

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18780      +/-   ##
==========================================
- Coverage   68.74%   68.71%   -0.03%     
==========================================
  Files         420      420              
  Lines       35512    35519       +7     
==========================================
- Hits        24411    24408       -3     
- Misses       9671     9682      +11     
+ Partials     1430     1429       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18eb5c6...3abdf61. Read the comment docs.

[jmhbnz]

/ok-to-test

[mmorel-35]

/retest

[mmorel-35]

/retest

[ivanvc]

LGTM. Thanks, @mmorel-35.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment