Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] [serverWatchStream] terminate recvLoop on sws.close() #18785

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

veshij
Copy link
Contributor

@veshij veshij commented Oct 26, 2024

backport of #18739 to 3.4

Signed-off-by: Oleg Guba <oleg.guba@gmail.com>
@k8s-ci-robot
Copy link

Hi @veshij. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Oct 26, 2024

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, veshij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 47b5f07 into etcd-io:release-3.4 Oct 26, 2024
18 checks passed
@ivanvc
Copy link
Member

ivanvc commented Oct 28, 2024

/retitle [3.4] [serverWatchStream] terminate recvLoop on sws.close()

@k8s-ci-robot k8s-ci-robot changed the title [serverWatchStream] terminate recvLoop on sws.close() [3.4] [serverWatchStream] terminate recvLoop on sws.close() Oct 28, 2024
@ahrtr
Copy link
Member

ahrtr commented Nov 1, 2024

Link to #18704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants