Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable errorlint in etcdctl and etcdutl directories #18813

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mmorel-35
Copy link
Contributor

This enable errorlint in etcdctl and etcdutl directories

Related to #18576

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (6883308) to head (5f2c6a6).

Current head 5f2c6a6 differs from pull request most recent head ff632e4

Please upload reports for the commit ff632e4 to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/lease_command.go 0.00% 4 Missing ⚠️
etcdctl/ctlv3/command/member_command.go 0.00% 3 Missing ⚠️
etcdutl/etcdutl/migrate_command.go 0.00% 3 Missing ⚠️
etcdctl/ctlv3/command/lock_command.go 0.00% 2 Missing ⚠️
etcdctl/ctlv3/command/user_command.go 0.00% 2 Missing ⚠️
etcdctl/ctlv3/command/auth_command.go 0.00% 1 Missing ⚠️
etcdctl/ctlv3/command/ep_command.go 0.00% 1 Missing ⚠️
etcdctl/ctlv3/command/put_command.go 0.00% 1 Missing ⚠️
etcdctl/ctlv3/command/txn_command.go 0.00% 1 Missing ⚠️
etcdctl/ctlv3/command/watch_command.go 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/auth_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/ep_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/put_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/txn_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/watch_command.go 44.08% <0.00%> (ø)
etcdutl/etcdutl/defrag_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/lock_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/user_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/member_command.go 0.00% <0.00%> (ø)
etcdutl/etcdutl/migrate_command.go 0.00% <0.00%> (ø)
... and 1 more

... and 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18813      +/-   ##
==========================================
+ Coverage   68.75%   68.81%   +0.06%     
==========================================
  Files         420      420              
  Lines       35522    35523       +1     
==========================================
+ Hits        24422    24446      +24     
+ Misses       9669     9650      -19     
+ Partials     1431     1427       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6883308...ff632e4. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ee88ecc into etcd-io:main Oct 31, 2024
19 checks passed
@mmorel-35 mmorel-35 deleted the etcd-tl/errorlint branch October 31, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants