Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ivanvc as approver for .github, scripts and tools/rw-heatmaps #18894

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Nov 14, 2024

Let's recognize the fantastic work @ivanvc has been doing recently.

Of particular note was the recent rework of scripts/release.sh to use gh cli to automate creating GitHub releases. This saved us significant toil last release cycle earlier this week.

Given the excellent work Ivan has been doing in the areas of ci / tooling and his earlier efforts to rewrite tools/rw-heatmaps in golang I think it makes perfect sense for him to be an approver for these areas.

cc @etcd-io/maintainers-etcd

Signed-off-by: James Blair <mail@jamesblair.net>
@ahrtr
Copy link
Member

ahrtr commented Nov 14, 2024

Well deserved!

Thanks @ivanvc for the consistent hard work!

Note we can also grant @ivanvc the approver permission for workflows of all projects under sig-etcd.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (19aa0db) to head (3633b43).

Current head 3633b43 differs from pull request most recent head f26f657

Please upload reports for the commit f26f657 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18894      +/-   ##
==========================================
- Coverage   68.81%   68.75%   -0.06%     
==========================================
  Files         420      420              
  Lines       35532    35532              
==========================================
- Hits        24450    24429      -21     
- Misses       9658     9670      +12     
- Partials     1424     1433       +9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19aa0db...f26f657. Read the comment docs.

@wenjiaswe
Copy link
Contributor

+1 Well deserved, thank you Ivan for your great contribution consistently!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

Thanks @ivanvc, excellent work!

@serathius serathius merged commit 52188b5 into etcd-io:main Nov 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants