tools/benchmark: add flags for pprof to storage put #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiang90 sorry for that, I changed the place of the vars. PTAL. If a child command has at least one PersistentFlag, ancestors' PersistentFlag aren't inherited. The PR spf13/cobra#220 is adding a new type of flag that is inherited to children unconditionally. |
mitake
force-pushed
the
benchmark-pprof
branch
from
4078689
to
581c8c3
Compare
| @@ -46,6 +50,11 @@ func init() { | |||
| storagePutCmd.Flags().IntVar(&storageKeySize, "key-size", 64, "a size of key (Byte)") | |||
| storagePutCmd.Flags().IntVar(&valueSize, "value-size", 64, "a size of value (Byte)") | |||
| storagePutCmd.Flags().BoolVar(&txn, "txn", false, "put a key in transaction or not") | |||
|
|
|||
| // TODO: after the PR https://github.com/spf13/cobra/pull/220 is merged, the below pprof related flags should be moved to RootCmd | |||
| storagePutCmd.Flags().StringVar(&cpuProfPath, "cpuprof-path", "", "a path of file for storing cpu profile result") | |||
There was a problem hiding this comment.
can we change the flag to cpuprofile and memprofile. go blog post suggests the flag in that way (http://blog.golang.org/profiling-go-programs)
|
OK. LGTM. |
mitake
force-pushed
the
benchmark-pprof
branch
from
581c8c3
to
690d86d
Compare
|
@xiang90 updated the names of flags, PTAL. |
| @@ -46,6 +47,11 @@ func init() { | |||
| storagePutCmd.Flags().IntVar(&storageKeySize, "key-size", 64, "a size of key (Byte)") | |||
| storagePutCmd.Flags().IntVar(&valueSize, "value-size", 64, "a size of value (Byte)") | |||
| storagePutCmd.Flags().BoolVar(&txn, "txn", false, "put a key in transaction or not") | |||
|
|
|||
| // TODO: after the PR https://github.com/spf13/cobra/pull/220 is merged, the below pprof related flags should be moved to RootCmd | |||
| storagePutCmd.Flags().StringVar(&cpuProfPath, "cpuprofile", "", "a path of file for storing cpu profile result") | |||
There was a problem hiding this comment.
the path of file for storing cpu profile resut
|
@mitake Can you address last few nits? |
This commit adds flags for profiling with runtime/pprof to storage
put:
- --cpuprofile: specify a path of CPU profiling result, if it is not
empty, profiling is activated
- --memprofile: specify a path of heap profiling result, if it is not
empty, profiling is activated
Of course, the flags should be added to RootCmd ideally. However,
adding common flags that shared by children command requires the
ongoing PR: spf13/cobra#220 . Therefore this
commit adds the flags to storage put only.
mitake
force-pushed
the
benchmark-pprof
branch
from
690d86d
to
1c802e9
Compare
|
@xiang90 solved the nits, could you take a look? |
xiang90
added a commit
that referenced
this pull request
Jan 14, 2016
tools/benchmark: add flags for pprof to storage put
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds flags for profiling with runtime/pprof to storage
put:
empty, profiling is activated
empty, profiling is activated
Of course, the flags should be added to RootCmd ideally. However,
adding common flags that shared by children command requires the
ongoing PR: spf13/cobra#220 . Therefore this
commit adds the flags to storage put only.