embed: wait up to request-timeout for pending RPCs when closing #8267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test case? |
embed/etcd.go
Outdated
| // wait until all pending RPCs are finished | ||
| select { | ||
| case <-ch: | ||
| case <-time.After(10 * time.Second): |
There was a problem hiding this comment.
maybe use the election timeout? 10s seems too generous
gyuho
changed the title
gyuho
force-pushed
the
close-server
branch
2 times, most recently
from
29355cd
to
6bd7522
Compare
Both grpc.Server.Stop and grpc.Server.GracefulStop close the listeners first, to stop accepting the new connections. GracefulStop blocks until all clients close their open transports(connections). Unary RPCs only take a few seconds to finish. Stream RPCs, like watch, might never close the connections from client side, thus making gRPC server wait forever. This patch still calls GracefulStop, but waits up to 10s before manually closing the open transports. Address etcd-io#8224. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Ensure 'Close' returns in time when there are open connections (watch streams). Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
changed the title
|
lgtm once tests pass. Should this be backported? |
heyitsanthony
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both grpc.Server.Stop and grpc.Server.GracefulStop close the listeners
first, to stop accepting the new connections. GracefulStop blocks until
all clients close their open transports(connections). Unary RPCs
only take a few seconds to finish. Stream RPCs, like watch, might never
close the connections from client side, thus making gRPC server wait
forever.
This patch still calls GracefulStop, but waits up to 10s before manually
closing the open transports.
Address #8224.
@heyitsanthony #8224 (comment)
This stops all client listeners first (no more new RPCs), and wait up to request timeout before cutting existing transports, to give enough time for unary RPCs to be finished.