Dockerfile: Improve file permissions for docker build images using bind9 #8661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/etc/init.d/bind9 is run as the 'bind' user. This fixes file permissions for the configuration files added by the Dockerfile to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed when attempting to replicate #8608 using the very convenient
make docker-dns-srv-test-buildcommand added in #8628.On some system configurations bind9 failed to start in the container with 'permission denied' errors when accessing the config files added by the
Dockerfile. In my case the system configuration was Ubuntu trusty 14.04 and docker 1.12.6.I'm not entirely clear on why this succeeds on other system configurations, but since
/etc/init.d/bind9runs the daemon as the 'bind' user, setting the config file permissions appropriately seems like the way to go.