clientv3/balancer: propagate network-partition error to gRPC #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
client
branch
2 times, most recently
from
58953a8 to
56dc790
Compare
gyuho
force-pushed
the
client
branch
3 times, most recently
from
6260f0c to
b75c2ba
Compare
|
Still a few more CIs to fix But still, we've been doing retry wrong here efd7800.
|
So that time-outs on network partition can trigger connection resets to gRPC via Notify channel. Here we are expecting time-out errors, not gRPC transport-layer errors, so need manual unpin to trigger connection resets. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
When the server returns non-transient errors (e.g. rpctypes.ErrEmptyKey), balancer should not bother to switch endpoints and just exit with error. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
xiang90
reviewed
Oct 11, 2017
| @@ -66,15 +66,17 @@ func (c *Client) newRetryWrapper(isStop retryStopErrFunc) retryRpcFunc { | |||
| if logger.V(4) { | |||
| logger.Infof("clientv3/retry: error %v on pinned endpoint %s", err, pinned) | |||
| } | |||
| // do not switch endpoint when server is stopped | |||
| // (should exit on non-transient error) | |||
| if isStop(err) { | |||
There was a problem hiding this comment.
why this is non-transient error?
There was a problem hiding this comment.
@xiang90 For instance, rpctypes.ErrEmptyKey should not be retried.
There's a test for this https://github.com/coreos/etcd/blob/master/clientv3/integration/kv_test.go#L36-L52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that time-outs on network partition can trigger
connection resets to gRPC via Notify channel.
Here we are expecting time-out errors, not gRPC
transport-layer errors, so need manual unpin
to trigger connection resets.