Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: add dev scripts #8764

Merged
merged 3 commits into from
Nov 2, 2017
Merged

hack: add dev scripts #8764

merged 3 commits into from
Nov 2, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Oct 26, 2017

Adding some frequently used commands to Makefile under hack

@gyuho gyuho force-pushed the hack branch 3 times, most recently from 43eba23 to a2ba5a4 Compare October 26, 2017 16:07
@gyuho gyuho requested a review from xiang90 October 26, 2017 16:20
@gyuho gyuho force-pushed the hack branch 2 times, most recently from fbfbd49 to 60919c3 Compare October 26, 2017 22:20
@gyuho gyuho changed the title *: upgrade Go version in CIs, add hack dev scripts hack: add dev scripts Oct 31, 2017
@gyuho gyuho force-pushed the hack branch 2 times, most recently from 53a3173 to e9a61b1 Compare November 1, 2017 17:04
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiang90
Copy link
Contributor

xiang90 commented Nov 2, 2017

can we remove the stuff put inside e2e since they are not in our CI yet?

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Adding some frequently used commands.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Nov 2, 2017

@xiang90 I moved them all under hack/scripts-dev.
We can put them back when we address #8502.

@xiang90
Copy link
Contributor

xiang90 commented Nov 2, 2017

lgtm

@gyuho gyuho merged commit f8bec0f into etcd-io:master Nov 2, 2017
@gyuho gyuho deleted the hack branch November 2, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants