httpproxy: cancel requests when client closes a connection #9336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkday-pro
force-pushed
the
iss_9335_fix
branch
from
f650726
to
dfe12ed
Compare
|
lgtm |
|
Thanks! Is there anything special I need to do to get this fix into the v3.2 release stream? A v3.2.17 with this fix in would be really useful to us. |
|
^ @jpbetz We have a few other PRs to backport for 3.3 as well. |
gyuho
added a commit
that referenced
this pull request
Mar 8, 2018
…rigin-release-3.2 Automated cherry pick of #9336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #9335. I've:
io.Copydoes now exit (so we don't leak a goroutine)cancel()repeatedly (https://golang.org/pkg/context/#CancelFunc - "After the first call, subsequent calls to a CancelFunc do nothing.")