embed: fix revision-based compaction retention parsing #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
taking a look! |
fanminshi
reviewed
Feb 21, 2018
embed/config_test.go
Outdated
| @@ -128,6 +128,15 @@ func TestUpdateDefaultClusterFromNameOverwrite(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestInvalidAutoCompactionMode(t *testing.T) { | |||
There was a problem hiding this comment.
maybe add another test to the issue scenario:
cfg := NewConfig()
cfg.AutoCompactionMode = "revision"
cfg.AutoCompactionRetention = "1"
srv, err := embed.StartEtcd(cfg)
// verify that srv.Config().AutoCompactionRetention == time.Duration(1)
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
fix-embed-auto-compact
branch
from
6ab320d to
83d1c3d
Compare
|
lgtm |
1 similar comment
|
lgtm |
gyuho
changed the title
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9337.