Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: clarify "WithRequireLeader" for network partition #9872

Merged
merged 1 commit into from
Jun 20, 2018
Merged

clientv3: clarify "WithRequireLeader" for network partition #9872

merged 1 commit into from
Jun 20, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jun 20, 2018 •
edited
Loading

@gyuho
clientv3: clarify "WithRequireLeader" for network partition
11ead62 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
jpbetz
jpbetz approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. I'll review the k8s use case as part of the stale read fix and apply WithRequireLeader as appropriate there.

lgtm

@gyuho
Copy link
Contributor Author

gyuho commented Jun 20, 2018

@jpbetz Yeah, I just tested 3-node cluster, and confirmed that WithRequireLeader will help detect network partition. It's enabled by default for etcdctl, not still optional for clientv3.

@gyuho gyuho merged commit 7648841 into etcd-io:master Jun 20, 2018
@gyuho gyuho deleted the watch-clientv3 branch June 20, 2018 17:46
This was referenced Mar 25, 2020
Closed
Closed
@amyangfei amyangfei mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @jpbetz