Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gofail-go failpoint #30

Merged
merged 1 commit into from
Nov 18, 2022

Commits on Nov 16, 2022

  1. remove gofail-go failpoint

    My understanding is the main motivation to introduce gofail-go
    failpoint is to make sure it can't be updated by users once it's
    triggered. Instead, users have to delete/disable it firstly, and
    then set another term for the gofail-go failpoint.
    
    Two points:
    1. The gofail-go's Release is called in a separate goroutine, it might cause goroutine leak.
    2. It complicates the overall design & implementation without obvious benefit.
    
    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    ahrtr committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    82c6f34 View commit details
    Browse the repository at this point in the history