Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golang 1.20 minor release #51

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update to golang 1.20 minor release #51

merged 1 commit into from
Sep 19, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Sep 6, 2023

Quick maintenance to keep gofail in line with etcd-io/etcd and using a supported go version.

@ahrtr
Copy link
Member

ahrtr commented Sep 6, 2023

/opt/hostedtoolcache/go/1.2.2/

The workflow is trying to use a very old go version. Probably we need to specify the patch version as well, such as 1.20.7.

@jmhbnz jmhbnz force-pushed the master branch 2 times, most recently from 0c135b3 to 938da5a Compare September 6, 2023 10:54
Signed-off-by: James Blair <mail@jamesblair.net>
Copy link
Member Author

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ahrtr - Given we have now gone to 1.21 in etcd-io/main would you rather I update this PR to jump straight to 1.21 here, or merge this and do a later pr to go 1.21?

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

@ahrtr
Copy link
Member

ahrtr commented Sep 19, 2023

merge this and do a later pr to go 1.21?

on this, thx

@ahrtr ahrtr merged commit 1214d62 into etcd-io:master Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants