Ensure any service threads are created as daemon threads (redo).

Signed-off-by: Cristian Ferretti <cristianferretti@deephaven.io>
etcd-io · May 30, 2023 · 6c59cf6 · 6c59cf6
1 parent 80e2b38
commit 6c59cf6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/jetcd-core/src/main/java/io/etcd/jetcd/ClientBuilder.java b/jetcd-core/src/main/java/io/etcd/jetcd/ClientBuilder.java
@@ -47,7 +47,7 @@
 import com.google.common.collect.Streams;
 
 /**
- * ClientBuilder knows how to create an Client instance.
+ * ClientBuilder knows how to create a Client instance.
  */
 public final class ClientBuilder implements Cloneable {
 

diff --git a/jetcd-core/src/main/java/io/etcd/jetcd/impl/ClientConnectionManager.java b/jetcd-core/src/main/java/io/etcd/jetcd/impl/ClientConnectionManager.java
@@ -45,6 +45,7 @@
 import io.grpc.stub.AbstractStub;
 import io.netty.channel.ChannelOption;
 import io.vertx.core.Vertx;
+import io.vertx.core.VertxOptions;
 import io.vertx.grpc.VertxChannelBuilder;
 
 import com.google.common.util.concurrent.ListenableFuture;
@@ -174,7 +175,7 @@ ManagedChannelBuilder<?> defaultChannelBuilder(String target) {
             throw new IllegalArgumentException("At least one endpoint should be provided");
         }
         if (vertx == null) {
-            vertx = Vertx.vertx();
+            vertx = Vertx.vertx(new VertxOptions().setUseDaemonThread(true));
         }
         final VertxChannelBuilder channelBuilder = VertxChannelBuilder.forTarget(vertx, target);