io.etcd.jetcd.launcher.EtcdContainer -- Error deleting directory when using jetcd-tests on unit-testing. #1310
Comments
if (shouldMountDataDirectory) {
dataDirectory = createDataDirectory(node);
addFileSystemBind(dataDirectory.toString(), Etcd.ETCD_DATA_DIR, BindMode.READ_WRITE, SelinuxContext.SHARED);
}
@RegisterExtension
public static final EtcdClusterExtension CLUSTER = EtcdClusterExtension.builder()
.withNodes(1)
.withMountDirectory(false)
.build();
|
This is something that has nothing to do with the requirement of the container image but it is something implemented for our test suite which for some tests requires to manipulate the content of the data dir.
Before changing the behavior, you need to check what the current test suite is doing. In any case, this does not solve the issue but just hide it so it would be nice to find out if there is a way to make it working regardless of the flag. |
|
|
As stated in the previous comment, I do not have any issue to change it but:
Can you help us on that ? |
|
|
So I guess you can:
|
|
private static void deleteDataDirectory(Path dir) {
if (dir != null && Files.exists(dir)) {
try {
try (Stream<Path> stream = Files.walk(dir)) {
stream.sorted(Comparator.reverseOrder())
.map(Path::toFile)
.forEach(file -> {
file.setReadable(true, false);
file.setWritable(true, false);
file.setExecutable(true, false);
file.delete();
});
} catch (IOException e) {
LOGGER.error("Error deleting directory {}", dir, e);
}
} catch (Exception e) {
LOGGER.error("Error deleting directory {}", dir, e);
}
}
}·
|
|
I think this is an issue with your linux distro/WSL because on my linux computer, where I'm not root, this is what I get in my |
|
Again, I can change it to default but I need some help understanding the impact on the actual test suite of jetcd. |
linghengqian@DESKTOP-2OCN434:/tmp$ ls -la
总计 76
drwxr-xr-x 3 linghengqian linghengqian 4096 8月 7 22:31 jetcd_test_etcd0_15814517176251913946
drwxr-xr-x 3 linghengqian linghengqian 4096 8月 7 22:04 jetcd_test_etcd0_6561556027985872395
linghengqian@DESKTOP-2OCN434:/tmp/jetcd_test_etcd0_15814517176251913946$ ls -la
总计 40
drwxr-xr-x 3 linghengqian linghengqian 4096 8月 7 22:31 .
drwxrwxrwt 13 root root 28672 8月 7 22:40 ..
drwx------ 4 root root 4096 8月 7 22:31 member |
|
Not on my system: |
|
since those files are created by the etcd container, then it may be the docker setup. |
Error Log🙌[ERROR] 2024-08-07 23:15:52.502 [main] io.etcd.jetcd.launcher.EtcdContainer - Error deleting directory /home/linghengqian/TwinklingLiftWorks/git/public/shardingsphere/test/native/src/test/resources/jetcd_test_etcd/jetcd_test_etcd0_8823803269529779473
java.io.UncheckedIOException: java.nio.file.AccessDeniedException: /home/linghengqian/TwinklingLiftWorks/git/public/shardingsphere/test/native/src/test/resources/jetcd_test_etcd/jetcd_test_etcd0_8823803269529779473/member
at java.base/java.nio.file.FileTreeIterator.fetchNextIfNeeded(FileTreeIterator.java:87)
at java.base/java.nio.file.FileTreeIterator.hasNext(FileTreeIterator.java:103)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:556)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:546)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:611)
at io.etcd.jetcd.launcher.EtcdContainer.deleteDataDirectory(EtcdContainer.java:218)
at io.etcd.jetcd.launcher.EtcdContainer.close(EtcdContainer.java:251)
at io.etcd.jetcd.launcher.EtcdClusterImpl.close(EtcdClusterImpl.java:102)
at io.etcd.jetcd.test.EtcdClusterExtension.after(EtcdClusterExtension.java:108)
at io.etcd.jetcd.test.EtcdClusterExtension.afterAll(EtcdClusterExtension.java:90)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$18(ClassBasedTestDescriptor.java:462)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$19(ClassBasedTestDescriptor.java:462)
at org.junit.platform.commons.util.CollectionUtils.forEachInReverseOrder(CollectionUtils.java:217)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeAfterAllCallbacks(ClassBasedTestDescriptor.java:461)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:236)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:85)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:161)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:161)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:198)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:169)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:93)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:58)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:141)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:57)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:103)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:85)
at org.junit.platform.launcher.core.DelegatingLauncher.execute(DelegatingLauncher.java:47)
at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:63)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:57)
at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
Caused by: java.nio.file.AccessDeniedException: /home/linghengqian/TwinklingLiftWorks/git/public/shardingsphere/test/native/src/test/resources/jetcd_test_etcd/jetcd_test_etcd0_8823803269529779473/member
at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90)
at java.base/sun.nio.fs.UnixException.asIOException(UnixException.java:115)
at java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:477)
at java.base/java.nio.file.Files.newDirectoryStream(Files.java:481)
at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:301)
at java.base/java.nio.file.FileTreeWalker.next(FileTreeWalker.java:374)
at java.base/java.nio.file.FileTreeIterator.fetchNextIfNeeded(FileTreeIterator.java:83)
... 58 common frames omitted |
sudo apt update && sudo apt upgrade -y
sudo apt-get remove docker.io docker-doc docker-compose docker-compose-v2 podman-docker containerd runc
cd /tmp/
sudo apt-get install ca-certificates curl
sudo install -m 0755 -d /etc/apt/keyrings
sudo curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc
sudo chmod a+r /etc/apt/keyrings/docker.asc
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu \
$(. /etc/os-release && echo "$VERSION_CODENAME") stable" | \
sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin -y
sudo groupadd docker
sudo usermod -aG docker $USER
newgrp docker
docker run hello-world
|
|
maybe it could be possible to configure the user the container runs as when starting the etcd container but I don't have any experience on WSL nor a computer to test. I would appreciate if you can investigate more and I'd be happy to review a patch. |
|
Hi @linghengqian! No, I'm not running docker in rootless mode. |
|
|
|
For #1310 Signed-off-by: linghengqian <linghengqian@outlook.com>
@RegisterExtension
public static final EtcdClusterExtension CLUSTER = EtcdClusterExtension.builder()
.withNodes(1)
.build();
@RegisterExtension
public static final EtcdClusterExtension CLUSTER = EtcdClusterExtension.builder()
.withNodes(1)
.withUser("1000:1000")
.build();
@RegisterExtension
public static final EtcdClusterExtension CLUSTER = EtcdClusterExtension.builder()
.withNodes(1)
.withMountDirectory(false)
.build();
|
Please open a dedicated issue |
|
|
Fixed by #1390 |
Versions
Describe the bug
At the end of unit tests when using jetcd-tests, an error
io.etcd.jetcd.launcher.EtcdContainer -- Error deleting directoryis thrown. It doesn't prevent the test to run successfully, but I wonder if it's something wrong I'm doing.To Reproduce
Unit test logs:
Expected behavior
It is expected that this AccessDeniedException don't appear at all.
Additional context
The text was updated successfully, but these errors were encountered: