Test: Replace t.error/fatal with assert/request in [raft_test.go] #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDXY
force-pushed
the
replace-test-errors-with-assert-(raft_test.go)
branch
2 times, most recently
from
22288ae
to
c5a8c0d
Compare
pav-kv
approved these changes
Mar 1, 2024
|
Thank you for your review. I must admit that I may have been a bit hasty in submitting this PR with multiple errors and inconsistencies. And I'll try to double-check everything before the next commit. |
MrDXY
force-pushed
the
replace-test-errors-with-assert-(raft_test.go)
branch
4 times, most recently
from
d437e80
to
ac496c5
Compare
ahrtr
reviewed
Mar 3, 2024
Comment on lines
+430
to
+433
| if sm.id == campaignerID { | ||
| assert.Equal(t, StateLeader, sm.state, "preVote=%v: campaigning node %d", preVote, sm.id) | ||
| } else { | ||
| assert.Equal(t, StateFollower, sm.state, "preVote=%v: campaigning node %d, current node %d", preVote, campaignerID, sm.id) |
There was a problem hiding this comment.
Nice minor refactor & simplification!
Part of: etcd-io#146 Signed-off-by: Xinyuan Du <xinyuan.du@broadcom.cn>
MrDXY
force-pushed
the
replace-test-errors-with-assert-(raft_test.go)
branch
from
ac496c5
to
176e8a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Replacing t.Error/t.Fatal with assert/require
This commit tries to eliminates boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.
Changes Made:
Affected Files:
Part of: #146