Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating grpc_naming.md to match etcd-io/etcd PR 12669 #101

Merged
merged 1 commit into from
Feb 9, 2021
Merged

updating grpc_naming.md to match etcd-io/etcd PR 12669 #101

merged 1 commit into from
Feb 9, 2021

Conversation

nate-double-u
Copy link
Contributor

updating grpc_naming.md to match etcd-io/etcd PR etcd-io/etcd#12669 copy change

Related PR: etcd-io/etcd#12660

@nate-double-u
updating grpc_naming.md to match etcd-io/etcd PR etcd-io/etcd#12669 c…
e15ada2 
…opy change

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Contributor Author

nate-double-u commented Feb 8, 2021 •
edited
Loading

/cc @spzala @ptabor

@nate-double-u
Copy link
Contributor Author

Deploy preview: https://deploy-preview-101--etcd.netlify.app/docs/current/dev-guide/grpc_naming/

spzala
spzala approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spzala spzala merged commit eaccadf into etcd-io:master Feb 9, 2021
@nate-double-u nate-double-u deleted the 12669-copy-update branch February 9, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptabor ptabor ptabor approved these changes

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nate-double-u @spzala @ptabor