-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing site for v3.5 release #379
Conversation
@nate-double-u Found a little typo
Should be
|
Another typo
Should be
|
One more typo:
Should be
|
a7f40f1
to
c6839d9
Compare
The last force-push corrects the typos that @gyuho found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gyuho - not sure but may be we should mention in the first paragraph that etcd graduated from CNCF during this release time frame? cncf/toc#541 https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/
Something like "v3.5 makes it a first major release after etcd graduated from CNCF" with related hyperlink(s). |
Kind of late for last minute change since we are publishing this soon. Think CNCF is already mentioned here?
Defer to @nate-double-u |
c6839d9
to
e141f5c
Compare
last force-push updates the git version tag (I'm assuming it'll be |
There is still a couple hours left before the release window -- I'm happy to do a copy-edit pass if someone wants to write something up and add it. But I agree, if we do add something, we should do it very soon. |
@gyuho @nate-double-u I am good with what you decide. Thanks! |
If you decide to make a change, then may be something minimal like this in the first paragraph here that I could think of - "Today, we are releasing etcd 3.5. The past two years allowed for extensive iterations in fixing numerous bugs, identifying optimization opportunities at scale, and evolving its surrounding ecosystem. The etcd project also (graduated from CNCF)https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/ during this time frame. This release is the result of continuous evolution and grungy, thankless tasks done by the etcd community." |
@gyuho Sounds good, thanks! |
how about this (in the same space as you're suggesting): The etcd project also became a CNCF graduated project during this time frame. |
That sounds good to me. Thanks @nate-double-u Defer to @gyuho I am also find to disregard my comment if it's late. |
Updating latest Changing v3.5-DRAFT to v3.5 Setting announcement blog draft status to false Setting v3.4 deprecation status Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
e141f5c
to
3f4939d
Compare
The latest force-push adds a line about CNCF graduation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks for the last minute change.
Preparing the site for v3.5 release.
Not to be merged before Jun 15, 2021 at 6:00 PM EDT.
Fixes: #376, #377
Contributes to: #328
Deploy previews
Redirect tests