Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing site for v3.5 release #379

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Preparing site for v3.5 release #379

merged 1 commit into from
Jun 15, 2021

Conversation

nate-double-u
Copy link
Contributor

@nate-double-u nate-double-u commented Jun 15, 2021

@gyuho
Copy link
Contributor

gyuho commented Jun 15, 2021

@nate-double-u Found a little typo

lilic@ Red Hat’s proposal

Should be

lilic@ of Red Hat’s proposal

@gyuho
Copy link
Contributor

gyuho commented Jun 15, 2021

Another typo

[kube-apiserver v1.21 code] (https://github.com/kubernetes/kubernetes/blob/v1.21.0/staging/src/k8s.io/client-go/tools/cache/reflector.go#L302-L312))

Should be

[kube-apiserver v1.21 code](https://github.com/kubernetes/kubernetes/blob/v1.21.0/staging/src/k8s.io/client-go/tools/cache/reflector.go#L302-L312)

@gyuho
Copy link
Contributor

gyuho commented Jun 15, 2021

One more typo:

[yangxuanjia@ of JD’s range stream proposal] (etcd-io/etcd#12343)

Should be

[yangxuanjia@ of JD’s range stream proposal](https://github.com/etcd-io/etcd/pull/12343)

@nate-double-u nate-double-u force-pushed the v3.5-release branch 2 times, most recently from a7f40f1 to c6839d9 Compare June 15, 2021 17:33
@nate-double-u
Copy link
Contributor Author

The last force-push corrects the typos that @gyuho found.

@nate-double-u nate-double-u mentioned this pull request Jun 15, 2021
9 tasks
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@gyuho - not sure but may be we should mention in the first paragraph that etcd graduated from CNCF during this release time frame? cncf/toc#541 https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/

@spzala
Copy link
Member

spzala commented Jun 15, 2021

lgtm
@gyuho - not sure but may be we should mention in the first paragraph that etcd graduated from CNCF during this release time frame? cncf/toc#541 https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/

Something like "v3.5 makes it a first major release after etcd graduated from CNCF" with related hyperlink(s).

@gyuho
Copy link
Contributor

gyuho commented Jun 15, 2021

Kind of late for last minute change since we are publishing this soon.

Think CNCF is already mentioned here?

New etcd.io
Since etcd joined Cloud Native Computing Foundation (CNCF) in December 2018

Defer to @nate-double-u

@nate-double-u
Copy link
Contributor Author

last force-push updates the git version tag (I'm assuming it'll be v3.5.0, please correct me if I'm wrong).

@nate-double-u
Copy link
Contributor Author

nate-double-u commented Jun 15, 2021

Kind of late for last minute change since we are publishing this soon.

Think CNCF is already mentioned here?

New etcd.io
Since etcd joined Cloud Native Computing Foundation (CNCF) in December 2018

Defer to @nate-double-u

There is still a couple hours left before the release window -- I'm happy to do a copy-edit pass if someone wants to write something up and add it. But I agree, if we do add something, we should do it very soon.

@spzala
Copy link
Member

spzala commented Jun 15, 2021

@gyuho @nate-double-u I am good with what you decide. Thanks!

@spzala
Copy link
Member

spzala commented Jun 15, 2021

If you decide to make a change, then may be something minimal like this in the first paragraph here that I could think of - "Today, we are releasing etcd 3.5. The past two years allowed for extensive iterations in fixing numerous bugs, identifying optimization opportunities at scale, and evolving its surrounding ecosystem. The etcd project also (graduated from CNCF)https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/ during this time frame. This release is the result of continuous evolution and grungy, thankless tasks done by the etcd community."

@spzala
Copy link
Member

spzala commented Jun 15, 2021

Kind of late for last minute change since we are publishing this soon.

Think CNCF is already mentioned here?

New etcd.io
Since etcd joined Cloud Native Computing Foundation (CNCF) in December 2018

Defer to @nate-double-u

@gyuho Sounds good, thanks!

@nate-double-u
Copy link
Contributor Author

nate-double-u commented Jun 15, 2021

If you decide to make a change, then may be something minimal like this in the first paragraph here that I could think of - "Today, we are releasing etcd 3.5. The past two years allowed for extensive iterations in fixing numerous bugs, identifying optimization opportunities at scale, and evolving its surrounding ecosystem. The etcd project also (graduated from CNCF)https://www.cncf.io/announcements/2020/11/24/cloud-native-computing-foundation-announces-etcd-graduation/ during this time frame. This release is the result of continuous evolution and grungy, thankless tasks done by the etcd community."

how about this (in the same space as you're suggesting):

The etcd project also became a CNCF graduated project during this time frame.

@spzala
Copy link
Member

spzala commented Jun 15, 2021

That sounds good to me. Thanks @nate-double-u Defer to @gyuho I am also find to disregard my comment if it's late.

Updating latest

Changing v3.5-DRAFT to v3.5

Setting announcement blog draft status to false

Setting v3.4 deprecation status

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Contributor Author

The latest force-push adds a line about CNCF graduation.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the last minute change.

@nate-double-u nate-double-u merged commit ba37eaa into main Jun 15, 2021
@nate-double-u nate-double-u deleted the v3.5-release branch June 15, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish v3.5 release announcement
3 participants