Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging.md for 3.5+ to show zap as default #645

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Feb 23, 2023

As outlined in the blog announcing release 3.5[1] etcd now uses zap by default so we should update logging.md to reflect that from v3.5 onward:

The migration to structured logging is complete. etcd now defaults to zap logger that has a reflection-free, zero-allocation JSON encoder. We have deprecated capnslog that logged with reflection-based serialization.

[1]https://etcd.io/blog/2021/announcing-etcd-3.5/

Fixes #605

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz
Copy link
Member Author

jmhbnz commented Mar 3, 2023

Hey @spzala, @ahrtr - This one is a pretty small fix for our logging docs, can you please review?

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jmhbnz

cc @spzala

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks @jmhbnz

@spzala spzala merged commit a729e00 into etcd-io:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The v3.5 documentation also provides instructions on logging using capnslog.
3 participants