Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the example which showcases the snapshot maintenance operation. #83

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

renormalize
Copy link
Contributor

The proposed changes make things clearer about the snapshot hash information.

  • Snapshot hash is sent after the first occurance of r.remaining_bytes() == 0. See *: make sure snapshot save downloads SHA256 checksum etcd-io/etcd#11896 for more information.

  • If the snapshot operation is performed as shown in the example previously, restarting the etcd on the stored data from this won't succeed unless etcd is started with --skip-hash-check=true. This isn't necessary anymore since the final msg.message().await fetches the snapshot hash information.

etcd used:

etcd Version: 3.5.11
Git SHA: 3b252db4f
Go Version: go1.21.5
Go OS/Arch: darwin/arm64

etcd-client: v0.14.0

* Snapshot hash is sent after the first occurance of `r.remaining_bytes() == 0`.
  See etcd-io/etcd#11896 for more information.

* If the snapshot operation is performed as shown in the example previously,
  restarting the etcd on the stored data from this won't succeed unless etcd
  is started with `--skip-hash-check=true`.
  This isn't necessary anymore since the final `msg.message().await` fetches
  the snapshot hash information.
@davidli2010 davidli2010 merged commit 512a1f4 into etcdv3:master Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants