Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 + EIP100: Change difficulty adjustment to target mean block time including uncles #8

Conversation

meowsbits
Copy link
Member

Related to original question by @chunfu-yang in comment here.

@meowsbits
Copy link
Member Author

For further reference, it may be of interest to review the related ethereumproject/go-ethereum#334.

Copy link
Contributor

@zmitton zmitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useful especially since the ETC ethos is supposed to have a "capped total supply".

Come to think of it though... how is that 210,000,000 cap implemented? This seems like it could directly affect the same code.

Looking at ECIP 1017 it looks like they claim to have possibly accomplished something similar to EIP 100, but maybe in a different way?

In the current ETC reward schedule, the total reward for uncles is higher than the reward received by the miner who also includes uncles. In this state, a miner is significantly diluting the value of his reward by including these uncled blocks. By equalizing the rewards to uncle block miners with the rewards to miners who include an uncle block, the reward structure is more fairly distributed. In addition, equalizing the uncle rewards reduces the incentive for miners to set up an ETC “uncle farm,” and instead drives them to better secure the network by competing for the latest “real block.”

@meowsbits is ECIP 1017 already merged into multi-geth, and might it already solve this?

Copy link
Contributor

@soc1c soc1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 EIP-100 should be part of this spec.

@meowsbits
Copy link
Member Author

meowsbits commented Mar 19, 2019

@zmitton the ECIP1017 monetary policy is indeed included in multi geth now (it's necessary for ETC support); however that only describes the reward rates for block production, and doesn't deal directly with difficulty at all.

w/r/t the cap; the disinflation schedule reduces block miner reward (and similary uncle reward) by 20% every 5 million blocks.

@meowsbits meowsbits marked this pull request as ready for review March 19, 2019 17:06
@zmitton
Copy link
Contributor

zmitton commented Mar 19, 2019

ok, here was my thought: the point of EIP100 is because currently when uncles get added, it makes the total block reward (inflation) greater. And it currently will not cause the block time to decrease of the difficulty to increase, so it effectively allows a bug where miners can increase the inflation.

This is why I thought we could have the bug, and the 210M cap may not be as "ridged" as we had thought.

So this would be pro argument.

Then looking at EIP 1017 it said something about fixing uncle rewards that I did not quite understand.

Sounds like you are aware of how EIP 1017 works so looks good to me 👍

soc1c pushed a commit that referenced this pull request Mar 20, 2019
ECIP-1049: Change the ETC Proof of Work Algorithm to Keccak256
@meowsbits
Copy link
Member Author

Closing via #10, where this proposal has been included.

@meowsbits meowsbits closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants