Tx Encoding and decoding fix #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregTheGreek
previously approved these changes
Aug 9, 2019
r8d8
previously requested changes
Aug 9, 2019
GregTheGreek
approved these changes
Aug 10, 2019
9 tasks
noot
approved these changes
Aug 13, 2019
soc1c
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Added test for decoding old encoding function * Fixed decoding issue and improved tests to handle all cases including previous client * Add compatibility with previous version * Rename receipt storage variable
soc1c
added a commit
that referenced
this pull request
Aug 13, 2019
* Replace repository reference for accounts/abi/bind (#29) * docs: update badges (#34) * docs: add gitter badge * docs: add circle-ci badge * Update README.md * Update README.md * Update README.md * docs: update repository path * Update README.md * Tx Encoding and decoding fix (#33) * Added test for decoding old encoding function * Fixed decoding issue and improved tests to handle all cases including previous client * Add compatibility with previous version * Rename receipt storage variable * Storage and edge case fixes (#28) * Applied storage fixes and updates * Minor execution refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed status encoding functions from foundation who implicitly ommitted PostState which altered the logic of the functionality of the receipt encoding and decoding, which was not caught by the existing tests or tests pulled from foundation.
Issue was if a Receipt in storage contained the PostState and Status, the Status would not be translated over into the returned value in favour of the PostState (which was removed and irrelevant at the current block).
I made these changes to remain compatible with all previous versions and now stores all fields without ommitting the PostState as was previously intended, but optimizations can be made later. I also added tests to ensure the compatibility and test these edge cases to make sure no changes affect the compatibility.
Please ensure the tx status appears on receipts migrating from a previous version, I cannot test that specifically.
Fixes #23